Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Captions: Adjust side margins, remove boilerplate from Blockbase #275

Merged
merged 3 commits into from
Feb 4, 2022

Conversation

coreymckrill
Copy link
Contributor

  • Removes side margins from figcaption elements, since the figure
    container will already have some whitespace around it.
  • Except when the figure container is set to full-width, in which case
    some margin is applied to the right side.
  • Removes custom styles for the video block that came over from
    Blockbase, but do not appear to be intended for the News site design.

Relates to #274

Before After
before after
Full width
full-width

* Removes side margins from figcaption elements, since the figure
  container will already have some whitespace around it.
* Except when the figure container is set to full-width, in which case
  some margin is applied to the right side.
* Removes custom styles for the video block that came over from
  Blockbase, but do not appear to be intended for the News site design.

Relates to #274
@coreymckrill coreymckrill self-assigned this Feb 1, 2022
@coreymckrill
Copy link
Contributor Author

@beafialho Is this what you had in mind in #274 for image caption margins?

@beafialho
Copy link
Collaborator

Thank you @coreymckrill, the After screenshot above looks accurate. Let's add this caption rule to Image Compare blocks:

Captura de ecrã 2022-02-02, às 15 15 55

About full-width, is it possible to get it closer to the edge of the screen?

Captura de ecrã 2022-02-02, às 15 12 56

@coreymckrill
Copy link
Contributor Author

@beafialho

is it possible to get it closer to the edge of the screen?

Yep! The above commit makes it look like your mockup above.

Let's add this caption rule to Image Compare blocks

Is this just referring to the caption being centered for this type of block? If so, the changes in this PR already make that the case.

@beafialho
Copy link
Collaborator

Is this just referring to the caption being centered for this type of block? If so, the changes in this PR already make that the case.

Sorry @coreymckrill I should have been clearer. The point is to have the same right-aligned captions for image compare blocks and video blocks as we have for images.

@coreymckrill
Copy link
Contributor Author

Ah, ok! No worries, I'll tweak the styles.

@coreymckrill coreymckrill merged commit 667c3e8 into trunk Feb 4, 2022
@coreymckrill coreymckrill deleted the fix/274/figcaption branch February 4, 2022 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants