Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How-to block time input fields miss a label #10750

Closed
afercia opened this issue Aug 23, 2018 · 0 comments
Closed

How-to block time input fields miss a label #10750

afercia opened this issue Aug 23, 2018 · 0 comments
Milestone

Comments

@afercia
Copy link
Contributor

afercia commented Aug 23, 2018

Noticed while checking #10705

The "Time needed" hours and minutes fields need a label element, properly associated with for / id attributes.

Right now, they're unlabelled and announced just as "incrementable edit text" (that's the way number input fields are announced):

screen shot 2018-08-23 at 14 36 19

  • ideally, these fields should be wrapped in a fieldset element
  • "Time needed" should be the fieldset legend
  • to avoid visual changes, the missing labels could be visually hidden with screen-reader-text, though visible labels are always preferable

Needs #10706

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants