Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight in pop-up menus not visible #3

Closed
JanPokorny opened this issue Sep 7, 2021 · 3 comments
Closed

Highlight in pop-up menus not visible #3

JanPokorny opened this issue Sep 7, 2021 · 3 comments

Comments

@JanPokorny
Copy link
Contributor

Hello, it seems like this theme doesn't style the highlighted item in pop-up menus -- like the theme selection menu, for example ("Sepia" is selected, but you can't see that):
obrazek

Compare with other theme:
obrazek

This is specific to the keyboard-higlighted item -- hovering with mouse works fine.

@JanPokorny
Copy link
Contributor Author

Workaround (put in settings.json):

"workbench.colorCustomizations": {
    "[Sepia]": {
        "list.activeSelectionBackground": "#D4C8AC"
    }
}

@JanPokorny
Copy link
Contributor Author

Merging #4 should fix this

@ZYinMD ZYinMD closed this as completed in 73dcea6 Nov 13, 2021
ZYinMD added a commit that referenced this issue Nov 13, 2021
@ZYinMD
Copy link
Owner

ZYinMD commented Nov 13, 2021

Merged, thanks very much. My github email notification was not turned on for new issues submitted to my repos (I think it's off by default for everybody) so I never saw your issue and your PR, until I found it by pure chance today. Sorry for the late reply.

Merging PR is one thing, publishing the new change to the vscode extension marketplace is another - I believe I just did that too, by running the deploy script I made 2 years ago, which I no longer remember how it works, but it seems to have succeeded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants