Skip to content

Commit

Permalink
Drop check against oldest Rust version
Browse files Browse the repository at this point in the history
  • Loading branch information
@abonander
abonander committed Aug 1, 2017
1 parent e4665cf commit dbe35aa
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion .travis.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ language: rust
cache: cargo
sudo: false
rust:
- 1.16.0
- stable
- nightly
branches:
Expand Down

3 comments on commit dbe35aa

@cardoe
Copy link

@cardoe cardoe commented on dbe35aa Aug 6, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is actually something that's really recommended to have in a project so that uses know what the lowest version supported is. Currently based on your dependencies it appears that the lowest version supported is 1.17.0

@abonander
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, but maintaining this value is a small pain. It should really be integrated into Cargo so it doesn't have to be tested for.

@cardoe
Copy link

@cardoe cardoe commented on dbe35aa Aug 7, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be trivial if dependencies are appropriately pinned. The issue occurred because of bad maintenance of unicode-bidi. There was an issue opened servo/unicode-bidi#46.

Please sign in to comment.