-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iTunesBackupInfo Module Search Pattern #600
Comments
looks like the plist from josh's image has this path: |
But the Info.plist file is stored in the root of an iTunes Backup folder and is not part of Manifest.db |
nice catch, @Johann-PLW. i didnt notice as much of a slow down when running against itunes backups, but this will certainly help to speed it up. love the app icon add too. is there any other info about that app icon that would deserve building out a dynamic type handler for it to allow a popover displaying more details? (see #587) we still have an issue with the full file system dumps though, and thats where i noticed a significant slow down against josh's public image. we need to determine if the backup |
@JamesHabben, the app icon is embedded in base64 in the Info.plist file. The content of the 'PlaceholderIcon' key is just the binary content of a png picture. There is no additional info related to this icon. Regarding the issue related to the info.plist backup file. I used the FFS josh's public image and selected all modules. Before updating ileapp.py and ileappGUI.py, I had 8596 hits against "/info.plist" in ProcessedFilesLog.html file and iTunesBackupInfo module was executed. Not related to this issue, I would also like to discuss with you if we can find a solution for big HTML files. |
@Johann-PLW oh that's awesome then! I havent had a chance to test your change and made a bad assumption. Sorry for that. For the health data, probably makes sense to start a new issue and we can discuss options. |
Closing this out as the code that loads the list of plugins is excluding this from the plugins list, so this doesn't impact the file searching performance. see here: Lines 166 to 170 in 3c4438b
|
the
iTunesBackupInfo
module uses a very broad file pattern search of"paths": ('*Info.plist',),
and it causes almost 9,000 files (around half of the files written out) to be written from josh's ios15 image. this is a pretty big time sink when running with this module. is there any adjustments we can make to that search pattern to limit this impact? wouldnt the itunes backup info.plist files be near the root on an itunes backup source? and are they in a more known location on a FFS dump?The text was updated successfully, but these errors were encountered: