-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to use ./config remove --token ...
on a just-in-time runner
#2920
Comments
It looks like the runner CLI just writes the |
Thanks for the report @jenseng . @rentziass is taking a look! |
Thank you so much for the report @jenseng ❤️ I just found the issue: |
@jenseng the fix for this should now be generally available! Thanks again for the report, please feel free to reopen this if you're still having issues! |
For ARSS, I don't think this is fixed. While the server does return
|
Describe the bug
When an ephemeral runner is launched with just-in-time registration, you can't perform deregistration from the runner itself (say, if you want to automatically tear down idle runners after a period of time).
To Reproduce
Steps to reproduce the behavior:
./run.sh --jitconfig ${encoded_jit_config}
./config remove --token ${runner_removal_token}
Expected behavior
The runner should be removed
Runner Version and Platform
Version of your runner? 2.310.1
OS of the machine running the runner? Linux
What's not working?
You get the following output and prompt, followed by an error
When launching ephemeral runners with a registration token, they can be removed normally:
Observations and a workaround
I noticed that the
.runner
file is slightly different between JIT vs registration-token runners. Specifically, a JIT runner has nogitHubUrl
entry. I found that by adding this missing entry, the remove command then works as expected.So if this entry were automatically persisted during registration, it seems that would fix the bug.
The text was updated successfully, but these errors were encountered: