Skip to content

Commit

Permalink
Merge pull request #645 from adamralph/remove-net7
Browse files Browse the repository at this point in the history
remove .NET 7
  • Loading branch information
adamralph authored Jul 21, 2024
2 parents 1c68cae + 21701e5 commit a4fb3e1
Show file tree
Hide file tree
Showing 6 changed files with 4 additions and 11 deletions.
1 change: 0 additions & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ jobs:
with:
dotnet-version: |
6.0.418
7.0.405
8.0.101
- uses: actions/[email protected]
with:
Expand Down
2 changes: 1 addition & 1 deletion SimpleExec/Command.cs
Original file line number Diff line number Diff line change
Expand Up @@ -376,7 +376,7 @@ private static async Task RunAsync(
await process.StandardInput.WriteAsync(standardInput).ConfigureAwait(false);
process.StandardInput.Close();

#if NET7_0_OR_GREATER
#if NET8_0_OR_GREATER
readOutput = process.StandardOutput.ReadToEndAsync(cancellationToken);
readError = process.StandardError.ReadToEndAsync(cancellationToken);
#else
Expand Down
2 changes: 1 addition & 1 deletion SimpleExec/SimpleExec.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
<PackageReadmeFile>README.md</PackageReadmeFile>
<PackageReleaseNotes>https://github.com/adamralph/simple-exec/blob/main/CHANGELOG.md</PackageReleaseNotes>
<PublishRepositoryUrl>true</PublishRepositoryUrl>
<TargetFrameworks>net6.0;net7.0;net8.0</TargetFrameworks>
<TargetFrameworks>net6.0;net8.0</TargetFrameworks>
</PropertyGroup>

<ItemGroup>
Expand Down
2 changes: 1 addition & 1 deletion SimpleExecTester/SimpleExecTester.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<IsPackable>false</IsPackable>
<OutputType>Exe</OutputType>
<RollForward>major</RollForward>
<TargetFrameworks>net6.0;net7.0;net8.0</TargetFrameworks>
<TargetFrameworks>net6.0;net8.0</TargetFrameworks>
</PropertyGroup>

</Project>
6 changes: 0 additions & 6 deletions SimpleExecTests/Infra/Tester.cs
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,6 @@ internal static class Tester
#if NET6_0 && RELEASE
"../../../../SimpleExecTester/bin/Release/net6.0/SimpleExecTester.dll";
#endif
#if NET7_0 && DEBUG
$"../../../../SimpleExecTester/bin/Debug/net7.0/SimpleExecTester.dll";
#endif
#if NET7_0 && RELEASE
$"../../../../SimpleExecTester/bin/Release/net7.0/SimpleExecTester.dll";
#endif
#if NET8_0 && DEBUG
$"../../../../SimpleExecTester/bin/Debug/net8.0/SimpleExecTester.dll";
#endif
Expand Down
2 changes: 1 addition & 1 deletion SimpleExecTests/SimpleExecTests.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

<PropertyGroup>
<RollForward>major</RollForward>
<TargetFrameworks>net6.0;net7.0;net8.0</TargetFrameworks>
<TargetFrameworks>net6.0;net8.0</TargetFrameworks>
</PropertyGroup>

<ItemGroup>
Expand Down

0 comments on commit a4fb3e1

Please sign in to comment.