Renaming a File Doesn't dismiss context menu

[JeffryBooher]

The F2 shortcut to rename the selected file is enabled while a context menu is "open"

1. Right click in either the editor or the JSTree to invoke a context menu
2. Press F2

==> Selected file goes into rename mode but the context menu is still "open"

Shortcuts shouldn't really work while context menus are displayed but this isn't what brackets does normally. Brackets allows for the shortcut to be processed in most cases.

Pressing F3, for instance, will close the menu and invoke the find next. My guess is that pressing F2 should close whatever context menu is currently displayed.

[JeffryBooher]

This is similar to #4693 which Lance has a fix for

[lkcampbell]

@JeffryBooher, the fix for #4693 doesn't work for this issue though. My fix forces the rename to finish if the user right clicks on a file currently in renaming mode. But it doesn't do anything about putting the file into rename mode after the context menu is shown.

You make an interesting point about the shortcut keys working when a context menu is being shown. I tested this on several Windows programs, including Sublime, Notepad, and PSPad, and all of them keep shortcut keys from working when a context menu is being shown.

So, I agree with you, the expected behavior for this issue is a blocking of shortcut key behavior when a context menu is being shown.

[lkcampbell]

FBNC to @JeffryBooher

[JeffryBooher]

Fixed confirmed.