Maxiumum call stack error with paper chips in acceptance test

[arschmitz]

using the keyEvent helper in acceptance tests to add items to a paper-chips component causes a maximum call stack error in phantomjs but works fine in browser this is a huge pain for testing on travis though the code is simply

keyEvent('.chips-wrapper input', 'keyup', 13)

[cah-danmonroe]

I see this also with integration tests. We are using ember-native-dom-helpers

[arschmitz]

Just for reference I'm not using ember-native-dom-helpers. I have stopped using phantomjs but do actually see this in chrome too just there it seems to be random happening about 50% of the time.

[markdicksonjr]

It looks like "input.is('focus')" keeps returning false in ember-chips::inputFocus, causing focus to be set infinitely. And ember-native-dom-helpers::fillIn (and presumably the tests written by those not using ember-native-dom-helpers) will set focus, set text, fire 'input' event, fire 'change' event, sparking this infinite loop.

ember-chips::inputFocus:

inputFocus: function inputFocus(autocomplete) {
        var input = this.getInput();

        this.set('focusedElement', 'input');

        if (!this.get('content').length && !input.is(':focus')) {
          input.focus(); // THIS JUST KEEPS GETTING CALLED
        } else {
          this.set('activeChip', -1);
        }
        ...
}

This is very likely related to an open phantomjs bug: ariya/phantomjs#10427

[arschmitz]

@markdicksonjr this is 100% not a phantomjs bug. I stopped testing in phantom and it happens randomly in chrome too. Actually after upgrading to latest ember and latest ember-paper its no longer random and happens on every run.

[markdicksonjr]

@arschmitz I wrote tests around chips in #828 and fixed a small (missing) conditional check, and it no longer happens for me in Chrome at all