-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suppress pytest warnings due to test util classes #3660
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3660 +/- ##
=========================================
+ Coverage 97.9% 97.9% +<.01%
=========================================
Files 43 43
Lines 8556 8558 +2
Branches 1376 1376
=========================================
+ Hits 8377 8379 +2
Misses 74 74
Partials 105 105
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #3660 +/- ##
=========================================
+ Coverage 97.9% 97.9% +<.01%
=========================================
Files 43 43
Lines 8556 8558 +2
Branches 1376 1376
=========================================
+ Hits 8377 8379 +2
Misses 74 74
Partials 105 105
Continue to review full report at Codecov.
|
Cool! |
(cherry picked from commit e6cbce3) Co-authored-by: Cong <[email protected]>
(cherry picked from commit e6cbce3) Co-authored-by: Cong <[email protected]>
What do these changes do?
We are using pytest; by default it collects tests in:
test_*.py
Test*
Unfortunately this matches the
TestServer
/TestClient
classes in aiohttp. Since they have__init__()
methods they won't break tests, but there will be warnings:The easiest way would be to exclude these tests from pytest collection via
__test__ = False
. See https://stackoverflow.com/q/24614851/2038264Are there changes in behavior for the user?
N/A
Related issue number
N/A
Checklist
CONTRIBUTORS.txt
CHANGES
folder<issue_id>.<type>
for example (588.bugfix)issue_id
change it to the pr id after creating the pr.feature
: Signifying a new feature..bugfix
: Signifying a bug fix..doc
: Signifying a documentation improvement..removal
: Signifying a deprecation or removal of public API..misc
: A ticket has been closed, but it is not of interest to users.