-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aiohttp filtering out "Authorization" header #648
Comments
It seems my bad. According to wsgi and cgi specs, AUTHORIZATION header should be removed, but. In our case, server does no handle any basic auth stuff, so this headers may only be handled at application level, so aiohttp should not remove it. |
Well it's very likely that the authorization is handled at application level in any case, i wonder what is the rationale behind that spec. Anyway, thanks. |
@riccardocagnasso it often handled by webserver (nginx auth_basic and auth_basic_user_file, apache AuthType and AuthUserFile). In this case webserver removes raw AUTHORIZATION header and may add own header, like HTTP_REMOTE_USER. |
Yes, of course, but that's always optional because you can only go so far with basic authentication |
Apparently aiohttp is filtering out the "Authorization" header in aiohttp.wsgi:69 in create_wsgi_environ.
This bug was found while using aiopyramid + jwtauth, you can find more details (and an example project) on housleyjk/aiopyramid#14
The text was updated successfully, but these errors were encountered: