Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aiokafka bdist_rpm command fails #599

Closed
gabriel-tincu opened this issue Apr 3, 2020 · 3 comments
Closed

aiokafka bdist_rpm command fails #599

gabriel-tincu opened this issue Apr 3, 2020 · 3 comments

Comments

@gabriel-tincu
Copy link
Contributor

gabriel-tincu commented Apr 3, 2020

Describe the bug
running python setup.py bdist_rpm will fail during the collect debug information step,
namely when /usr/lib/rpm/find-debuginfo.sh will fail to retrieve any files from the generated debugsources.list file

Expected behaviour
I expect the rpm build step to succeed , regardless of missing debug info files. My fix basically ignores the generate debug info step, which seems to be the source of the issue. While i am fully aware that this is not as much a fix as it is a workaround, the effort involved to actually figure out the internals of rpmbuild would be large and the generated debug packages is for all intended purposes useless

Environment (please complete the following information):

  • aiokafka version 0.5.2
  • kafka-python version 1.4.3
  • OS: Fedora 31
    Reproducible example
python setup.py bdist_rpm
@gabriel-tincu gabriel-tincu changed the title aiokafka bdist_rpm command fails to complete aiokafka bdist_rpm command fails Apr 3, 2020
@gabriel-tincu
Copy link
Contributor Author

would be nice if someone had a look at the PR open for this

@tvoinarovskyi
Copy link
Member

@gabriel-tincu Sorry for the long wait, the fix seems nice, thanks! Are there any other issues with bdist? I never build an rpm package for it...

@gabriel-tincu
Copy link
Contributor Author

@gabriel-tincu Sorry for the long wait, the fix seems nice, thanks! Are there any other issues with bdist? I never build an rpm package for it...

Not really... tbh im very much a beginner when it comes to RPM's but in this case it was either this, or adopting a custom solution downstream... This is still a workaround rather than a fix unfortunately :(. Thanks for looking at it @tvoinarovskyi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants