Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust Heartbeats to follow KIP-62 #67

Closed
tvoinarovskyi opened this issue Nov 11, 2016 · 0 comments
Closed

Adjust Heartbeats to follow KIP-62 #67

tvoinarovskyi opened this issue Nov 11, 2016 · 0 comments
Assignees
Milestone

Comments

@tvoinarovskyi
Copy link
Member

tvoinarovskyi commented Nov 11, 2016

As mentioned in KIP-62 Kafka will (as of 0.10.1.0) have an ability to send HeartBeats from a Background thread.
aiokafka has done this from the start by design, as long as the event loop itself is spinning, but this KIP also proposes to limit the processing time by a different parameter max.poll.interval.ms. I think it is good to adapt the same idea for aiokafka so we assure message consumption progress on the client itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant