Updating akr setup to create config directories when needed. #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes updates to the
crates/kr/src/launch.rsandcrates/kr/src/setup.rsfiles to improve error handling and directory management. The most important changes include adding checks and creating directories if they don't exist, and updating imports for better file handling.Error handling and directory management improvements:
crates/kr/src/launch.rs: Added a check to create thelaunch_agents_directoryif it doesn't exist, and return an error if it cannot be created.crates/kr/src/setup.rs: Added logic to create the.sshdirectory and the SSH config file if they don't exist, and handle errors appropriately. If a custom config path is passed in, no directory is created. [1] [2]Code cleanup:
crates/kr/src/launch.rs: Removed unused importnix::unistd::Uid.crates/kr/src/setup.rs: Updated imports to includefsfor file handling.Fixes #151
I integrated some of the code from PR #11 in this PR (changes to
crates/kr/src/launch.rs)