Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packaged version 0.1.2 is malformed #7

Closed
busykai opened this issue Dec 17, 2013 · 9 comments
Closed

Packaged version 0.1.2 is malformed #7

busykai opened this issue Dec 17, 2013 · 9 comments

Comments

@busykai
Copy link

busykai commented Dec 17, 2013

Hi, it seems that version 0.1.2 was zipped incorrectly, it has structure

<root>.zip/
    _MACOSX/
    brackets_bower_dist/
        main.js

as a consequence Brackets cannot find the entry point.

@njx
Copy link
Collaborator

njx commented Dec 18, 2013

That should be fine - it works for me when I install it into Brackets (the extension loader should ignore the __MACOSX folder and find the main.js file in the subfolder).

However, it's possible that (if you went through the "Update" workflow to get the new version) you ran into a Brackets issue that I noticed when upgrading the extension. When you click Update, exit Extension Manager and choose "Update Extensions and Quit", Brackets can hang for a little while trying to update this specific extension (because it has a lot of node modules in it). If you did something like force quit at that point (or do what I did and try to re-enter the Extension Manager dialog to re-update the extension :)), it can corrupt the installation of the extension. In that case, just removing and reinstalling the extension should fix the problem. I filed this as adobe/brackets#6257.

Let me know if you're seeing something else.

@Den-dp
Copy link

Den-dp commented Dec 18, 2013

I even can't update the bower extension in Brackets because I get the following error message
update-extension
Maybe this is related?

@busykai
Copy link
Author

busykai commented Dec 18, 2013

@Den-dp This is what I've been seeing. Only on bower extension, others work. Downloading and copying it manually works. I assumed it was malformed. Let me look into it and understand what exactly is going on...

@njx
Copy link
Collaborator

njx commented Dec 18, 2013

Weird. Maybe this is the same as adobe/brackets#4609. Are you both on Windows? I've seen issues where I've zipped the file on the Mac (using Finder) and it's caused problems, but I thought the only issue there was the __MACOSX folder, which we should be explicitly ignoring. But maybe there's some other problem with Finder-created ZIPs.

I'll try re-zipping from the command line and see if that fixes things.

@njx
Copy link
Collaborator

njx commented Dec 18, 2013

I just uploaded a new ZIP that was created from the command line. Please try again and let me know if it works for you. (Also, note that quitting Brackets after updating will take a significant amount of time, as mentioned above.)

@busykai
Copy link
Author

busykai commented Dec 18, 2013

@njx , thanks! This one installs and updates fine. I'm on windows and I do have a copy of the 0.1.2 version. I'll try to get to the bottom of this. All flavors of unzip I have installed on the machine opened the archive just fine.

@Den-dp
Copy link

Den-dp commented Dec 18, 2013

Nice! Build 0.1.3 works perfectly for me. Error message no longer appears. (Windows 7, x64)

@njx
Copy link
Collaborator

njx commented Dec 18, 2013

Thanks @busykai - let us know what you find. Closing.

@njx njx closed this as completed Dec 18, 2013
@njx
Copy link
Collaborator

njx commented Dec 18, 2013

BTW, I filed adobe/brackets#6267 on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants