Move to pyteal as pt in ABI tests #285
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tzaffi
reviewed
Apr 20, 2022
Co-authored-by: Zeph Grunschlag <[email protected]>
tzaffi
reviewed
Apr 20, 2022
| options = pt.CompileOptions(version=5) | ||
|
|
||
| STATIC_TYPES: List[pt.abi.TypeSpec] = [ | ||
| pt.abi.BoolTypeSpec(), |
There was a problem hiding this comment.
👍
pt.abi... caught me by surprise, but is certainly in the spirit of incoming CONTRIBUTING.md
There was a problem hiding this comment.
nit: I'd probably recommend something like this:
import pyteal as pt
from pyteal import abiI don't mind the two imports in this case, and since it would require fewer changes in this PR, I have a preference for it, but this is not a blocker to me.
tzaffi
reviewed
Apr 20, 2022
jasonpaulos
approved these changes
Apr 20, 2022
| options = pt.CompileOptions(version=5) | ||
|
|
||
| STATIC_TYPES: List[pt.abi.TypeSpec] = [ | ||
| pt.abi.BoolTypeSpec(), |
There was a problem hiding this comment.
nit: I'd probably recommend something like this:
import pyteal as pt
from pyteal import abiI don't mind the two imports in this case, and since it would require fewer changes in this PR, I have a preference for it, but this is not a blocker to me.
…algorand/pyteal into feature/abi-merge_master-remove_ignores
|
Closing - We opted for the approach in #286. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows #284 to remove temporary flake8 ignores.
Except for
method_return_test.py, all changes made mechanically viapyteal-as-pt.txt. Rename to
.shafter downloading because Github allows limited upload formats.