Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

修复OceanBase validateQuery问题 #4967

Merged
merged 1 commit into from
Oct 20, 2022
Merged

Conversation

PeppaO
Copy link
Contributor

@PeppaO PeppaO commented Oct 20, 2022

druid通过jdbc前缀来区分是mysql租户还是oracle租户这种方式是不准确的,因为oceanbase官方给的是两种租户都可以采用jdbc:oceanbase://host:port方式进行连接,所以当我采用这种方式的时候,druid就会报错

@PeppaO
Copy link
Contributor Author

PeppaO commented Oct 20, 2022

Caused by: java.sql.SQLException: ORA-00900: You have an error in your SQL syntax; check the manual that corresponds to your OceanBase version for the right syntax to use near ''x'' at line 1

@PeppaO
Copy link
Contributor Author

PeppaO commented Oct 20, 2022

已测试通过

@codecov-commenter
Copy link

codecov-commenter commented Oct 20, 2022

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 58.93%. Comparing base (118c21c) to head (aad1826).
Report is 878 commits behind head on master.

Files with missing lines Patch % Lines
...d/pool/vendor/OceanBaseValidConnectionChecker.java 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #4967   +/-   ##
=========================================
  Coverage     58.93%   58.93%           
- Complexity    26908    26910    +2     
=========================================
  Files          1268     1268           
  Lines        122755   122752    -3     
  Branches      23123    23122    -1     
=========================================
  Hits          72350    72350           
+ Misses        41385    41383    -2     
+ Partials       9020     9019    -1     
Files with missing lines Coverage Δ
...d/pool/vendor/OceanBaseValidConnectionChecker.java 0.00% <0.00%> (ø)

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 118c21c...aad1826. Read the comment docs.

@wenshao wenshao merged commit 569f4a6 into alibaba:master Oct 20, 2022
@wenshao wenshao added this to the 1.2.14 milestone Oct 23, 2022
@wenshao
Copy link
Member

wenshao commented Oct 23, 2022

@PeppaO PeppaO deleted the fix_PeppaO branch November 2, 2022 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants