Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: minor fix for error misuse #2277

Merged
merged 1 commit into from
Sep 26, 2018

Conversation

YaoZengzeng
Copy link
Contributor

Signed-off-by: YaoZengzeng [email protected]

Ⅰ. Describe what this PR did

fix the misuse of the error returned by removing container

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov
Copy link

codecov bot commented Sep 26, 2018

Codecov Report

Merging #2277 into master will increase coverage by 0.06%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2277      +/-   ##
==========================================
+ Coverage   66.76%   66.83%   +0.06%     
==========================================
  Files         208      208              
  Lines       16937    16937              
==========================================
+ Hits        11308    11319      +11     
+ Misses       4267     4260       -7     
+ Partials     1362     1358       -4
Flag Coverage Δ
#criv1alpha1test 32.63% <0%> (+0.02%) ⬆️
#criv1alpha2test 35.96% <0%> (-0.02%) ⬇️
#integrationtest 39.54% <0%> (-0.02%) ⬇️
#nodee2etest 33.45% <0%> (+0.12%) ⬆️
#unittest 23.75% <0%> (ø) ⬆️
Impacted Files Coverage Δ
cri/v1alpha1/cri.go 62.21% <0%> (+0.33%) ⬆️
daemon/logger/jsonfile/jsonfile.go 69.23% <0%> (-7.7%) ⬇️
apis/server/utils.go 61.9% <0%> (-4.77%) ⬇️
ctrd/watch.go 75.75% <0%> (-4.55%) ⬇️
daemon/logger/jsonfile/utils.go 71.54% <0%> (-1.63%) ⬇️
daemon/mgr/container.go 57.39% <0%> (ø) ⬆️
cri/v1alpha2/cri_utils.go 90.62% <0%> (+0.29%) ⬆️
cri/v1alpha2/cri.go 67.06% <0%> (+0.29%) ⬆️
ctrd/container.go 60.23% <0%> (+0.47%) ⬆️
... and 4 more

@pouchrobot pouchrobot added kind/bug This is bug report for project os/suse size/XS labels Sep 26, 2018
@sunyuan3
Copy link
Contributor

LGTM

@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label Sep 26, 2018
Copy link
Contributor

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fuweid fuweid merged commit a300ed8 into AliyunContainerService:master Sep 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug This is bug report for project LGTM one maintainer or community participant agrees to merge the pull reuqest. os/suse size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants