bugfix: container log path map not initialized for existing businesses #2559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2559 +/- ##
=========================================
+ Coverage 69.09% 69.2% +0.11%
=========================================
Files 278 278
Lines 18582 18564 -18
=========================================
+ Hits 12839 12847 +8
+ Misses 4270 4256 -14
+ Partials 1473 1461 -12
|
starnop
force-pushed
the
bugfix-configmap
branch
from
98f739e to
c7ef7cc
Compare
zhuangqh
reviewed
Dec 13, 2018
cri/v1alpha2/cri.go
Outdated
| logPath, ok := sandboxMeta.ContainerLogMap[containerID] | ||
| if !ok { | ||
| logPath, ok := container.Config.Labels[containerLogPathLabelKey] | ||
| if !ok || logPath == "" { |
There was a problem hiding this comment.
just checkout logPath is empty here. No matter ok is true or false. right?
starnop
force-pushed
the
bugfix-configmap
branch
2 times, most recently
from
ffe4b17 to
3c2825a
Compare
Signed-off-by: Starnop <[email protected]>
starnop
force-pushed
the
bugfix-configmap
branch
from
3c2825a to
a93b5bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Starnop [email protected]
Ⅰ. Describe what this PR did
For existing businesses, ContainerLogMap has not been initialized which will cause panic, so fix it.
Ⅱ. Does this pull request fix one issue?
None.
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
None.
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews