Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Horizontal scrollbars are appearing in story editor #2566

Closed
swissspidy opened this issue Jun 11, 2019 · 9 comments · Fixed by #2569
Closed

Horizontal scrollbars are appearing in story editor #2566

swissspidy opened this issue Jun 11, 2019 · 9 comments · Fixed by #2569
Labels
Bug Something isn't working
Milestone

Comments

@swissspidy
Copy link
Collaborator

swissspidy commented Jun 11, 2019

image

@swissspidy swissspidy added [AMP Stories] Navigation UI Bug Something isn't working labels Jun 11, 2019
@westonruter
Copy link
Member

This happens particularly on the first page:

image

On the second page, the scrollbar goes away:

image

@swissspidy
Copy link
Collaborator Author

As an explanation, that the width of 1110 is coming from the width of the wrapping #amp-story-editor element. #amp-story-editor > .editor-block-list__layout then uses flexbox to lay out the inner blocks horizontally.

@westonruter
Copy link
Member

Can we just add overflow:hidden on the #amp-story-editor? That seems to fix the problem for me.

@swissspidy
Copy link
Collaborator Author

swissspidy commented Jun 11, 2019

As mentioned on Slack, a simple overflow: hidden there is not going to work. This will cut off elements all over the place. Quick example:

Screenshot 2019-06-11 at 18 55 33

@westonruter
Copy link
Member

westonruter commented Jun 11, 2019

This is the only place I see an element being cut off when I add overflow:hidden to #amp-story-editor:

image

Which seems just fine.

@swissspidy
Copy link
Collaborator Author

Note that .amp-story-editor-carousel-navigation needs more top margin there, at least margin-top: 7em;. Or ideally the elements above would automatically push it down. 🤷‍♂

@westonruter
Copy link
Member

@swissspidy in regards to the CTA block on the first page, what if the warning were displayed instead of the block? Or above the block?

image

@swissspidy
Copy link
Collaborator Author

That works too. Still think the margin needs to be increased a bit though.

@csossi
Copy link

csossi commented Jun 12, 2019

Verified in QA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants