Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AMP validation error: The attribute 'height' may not appear in tag 'symbol'. #23259

Closed
kmturley opened this issue Jul 10, 2019 · 3 comments
Closed

Comments

@kmturley
Copy link

What's the issue?

AMP says it supports SVG in the spec:
https://amp.dev/documentation/guides-and-tutorials/learn/spec/amphtml#svg

But when using an SVG symbol for example:
https://developer.mozilla.org/en-US/docs/Web/SVG/Element/symbol

It throws an error:

AMP validation had errors:
The attribute 'height' may not appear in tag 'symbol'.
The attribute 'width' may not appear in tag 'symbol'.

How do we reproduce the issue?

Example here:
https://jsbin.com/mukisaf/edit?html,console,output

Steps to reproduce:

  1. Create a default AMP page
  2. Copy in the example SVG from https://developer.mozilla.org/en-US/docs/Web/SVG/Element/symbol
  3. Run the page using the development validator url param: #development=1

What browsers are affected?

All browsers

Which AMP version is affected?

v0.1

@dreamofabear
Copy link

@ampproject/wg-caching

@Gregable
Copy link
Member

It looks like width and height were added to that document in October 2018:

They should be added to the AMP spec as well.

@Gregable Gregable self-assigned this Aug 7, 2019
@Gregable
Copy link
Member

Gregable commented Aug 8, 2019

Fixed

@Gregable Gregable closed this as completed Aug 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants