Skip to content

Commit

Permalink
refactor(@angular/build): remove no longer correct type
Browse files Browse the repository at this point in the history
`buildApplication` no longer yields the `outputFiles` and `assetFiles`.
  • Loading branch information
alan-agius4 committed Jan 7, 2025
1 parent b78ccb0 commit f3c6dfe
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 24 deletions.
13 changes: 1 addition & 12 deletions goldens/public-api/angular/build/index.api.md
Original file line number Diff line number Diff line change
Expand Up @@ -71,19 +71,8 @@ export interface ApplicationBuilderOptions {
webWorkerTsConfig?: string;
}

// @public (undocumented)
export interface ApplicationBuilderOutput extends BuilderOutput {
// (undocumented)
assetFiles?: {
source: string;
destination: string;
}[];
// (undocumented)
outputFiles?: BuildOutputFile[];
}

// @public
export function buildApplication(options: ApplicationBuilderOptions, context: BuilderContext, extensions?: ApplicationBuilderExtensions): AsyncIterable<ApplicationBuilderOutput>;
export function buildApplication(options: ApplicationBuilderOptions, context: BuilderContext, extensions?: ApplicationBuilderExtensions): AsyncIterable<BuilderOutput>;

// @public (undocumented)
export interface BuildOutputAsset {
Expand Down
9 changes: 2 additions & 7 deletions packages/angular/build/src/builders/application/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import { BuilderContext, BuilderOutput, createBuilder } from '@angular-devkit/ar
import assert from 'node:assert';
import fs from 'node:fs/promises';
import path from 'node:path';
import { BuildOutputFile, BuildOutputFileType } from '../../tools/esbuild/bundler-context';
import { BuildOutputFileType } from '../../tools/esbuild/bundler-context';
import { createJsonBuildManifest, emitFilesToDisk } from '../../tools/esbuild/utils';
import { colors as ansiColors } from '../../utils/color';
import { deleteOutputDir } from '../../utils/delete-output-dir';
Expand Down Expand Up @@ -133,11 +133,6 @@ export async function* buildApplicationInternal(
);
}

export interface ApplicationBuilderOutput extends BuilderOutput {
outputFiles?: BuildOutputFile[];
assetFiles?: { source: string; destination: string }[];
}

/**
* Builds an application using the `application` builder with the provided
* options.
Expand All @@ -156,7 +151,7 @@ export async function* buildApplication(
options: ApplicationBuilderOptions,
context: BuilderContext,
extensions?: ApplicationBuilderExtensions,
): AsyncIterable<ApplicationBuilderOutput> {
): AsyncIterable<BuilderOutput> {
let initial = true;
const internalOptions = { ...options, incrementalResults: true };
for await (const result of buildApplicationInternal(internalOptions, context, extensions)) {
Expand Down
6 changes: 1 addition & 5 deletions packages/angular/build/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,7 @@
* found in the LICENSE file at https://angular.dev/license
*/

export {
buildApplication,
type ApplicationBuilderOptions,
type ApplicationBuilderOutput,
} from './builders/application';
export { buildApplication, type ApplicationBuilderOptions } from './builders/application';
export type { ApplicationBuilderExtensions } from './builders/application/options';
export { type BuildOutputFile, BuildOutputFileType } from './tools/esbuild/bundler-context';
export type { BuildOutputAsset } from './tools/esbuild/bundler-execution-result';
Expand Down

0 comments on commit f3c6dfe

Please sign in to comment.