-
Notifications
You must be signed in to change notification settings - Fork 12k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regression with npm dependencies #3023
Comments
PR #2291 disables node's module resolution algorithm. I had to change it locally as well. |
@filipesilva, So what's happening is that PR #2291 forces webpack to only look for packages in the first level of the projects local I dug through webpack's dependency resolution code after #2291 was merged and it looks like my suggested change from that PR is the proper way to define a backup module resolution strategy. |
@clydin thank you for the analysis and solution. Would you be available to do a PR with your solution? |
So there are two parts. If just the CLI's webpack module resolution is changed, it would fix this issue but it would break npm linked angular libraries again (AOT mode should work though). The current typescript loader would need changes as well for a complete fix. I have some experiments done for this but nothing concrete. (It also looks like there is some major refactoring taking place for the next version). Also, ts-loader handles dependency resolution differently than ATL, so that could potentially be an option as well. |
We might be looking at making the AoT loader our default one in the future, so that information is definitely useful. Thank you. |
Any news or something we can help with? Our team is halted at |
Closing this as AOT compatible libraries are needed now. Most libraries that we contacted already published AOT-compatible versions on npm. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
OS?
Linux x64
Versions.
Could not start watchman; falling back to NodeWatcher for file system events.
Visit http://ember-cli.com/user-guide/#watchman for more info.
angular-cli: 1.0.0-beta.19-3
node: 6.9.1
os: linux x64
Repro steps.
My project is stable right now in beta.17 trying to use beta.18 or beta.19-3 on npm.
The log given by the failure.
Mention any other details that might be useful.
Webpack seems to wrongly resolve indirect dependencies. To be more precise:
0) Grab a
ng new
projectoldY
).newY
).ng serve
(looking at the main bundle if you wish), package X will receivenewY
instead.I personally did these tests for packages X =
jsonapi-serializer
, Y =lodash
(or Y =bluebird
)This error seems to be related to #2291. Commenting out the line changed in this PR makes webpack resolve correctly as before.
The text was updated successfully, but these errors were encountered: