Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Valkey #290

Open
HarlemSquirrel opened this issue Jan 21, 2025 · 4 comments
Open

Support Valkey #290

HarlemSquirrel opened this issue Jan 21, 2025 · 4 comments
Labels

Comments

@HarlemSquirrel
Copy link

I recently learned about Valkey so it would be awesome to have support for that here.

AWS ElastiCache recently added Valkey as well:
https://aws.amazon.com/about-aws/whats-new/2024/10/amazon-elasticache-valkey/

@animir animir added the feature label Jan 21, 2025
@animir
Copy link
Owner

animir commented Jan 21, 2025

@HarlemSquirrel Hey, is it used widely? Would you like to add a new RateLimiterValkey?
Btw, it is a good name for key-value storage. :)

@HarlemSquirrel
Copy link
Author

I'm not sure how widely it's used yet. Just learned about it from a co-worker through that AWS article. The GitHub project has 18k stars: https://github.com/valkey-io/valkey

I'm not using this library yet but I came across it while researching for an upcoming project. We may not add any libraries for rate limiting but I wanted to see if there was any interest here in supporting Valkey since I heard some good things. 😁

@Clebiez
Copy link

Clebiez commented Feb 17, 2025

Valkey has been launched last year by Linuxfoundation and is backed by over 40+ companies including AWS, Google, Oracle. It seems to be something very cool :)

Valkey can be connected using ioredis according to this article, that's why I think it can works actually with the RateLimiterRedis class: https://community.aws/content/2hx81ITCvDiWqrAz06SECOvepoa/getting-started-with-valkey-using-javascript#use-valkey-with-ioredis

But it could be better to have a separated connector using official fork of ioredis for valkey -> iovalkey

Once again, iovalkey is a fork of ioredis and are actually very close. It's possible that RateLimiterRedis and iovalkey works together.

@gurgunday
Copy link

gurgunday commented Feb 23, 2025

I'm also interested in this - Valkey is awesome!

There are 2 important clients, iovalkey and Valkey GLIDE

I wanted to make a PR for both them but it seems difficult to create one RateLimtier class for both

I think I'll do 2 classes, RateLimiterValkey for iovalkey, and RateLimiterGlide or RateLimiterValkeyGlide for the other

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants