Compute new entrypoint root when loading a file in the REPL #1615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulcadman
force-pushed
the
repl-shelltests
branch
2 times, most recently
from
ff89f42 to
49990d5
Compare
Previously the REPL would use app root (which could be the current directory or the project root of the initially loaded file). Thus files in a different project could not be loaded. The entrypoint root must be computed each time a new file is `:load`ed. Adds shell-tests for REPL commands
paulcadman
force-pushed
the
repl-shelltests
branch
from
49990d5 to
e89462f
Compare
janmasrovira
reviewed
Nov 9, 2022
janmasrovira
approved these changes
Nov 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the REPL would use the
Appeffect root (which could be the current directory or the project root of the initially loaded file). Thus files in a different Juvix project could not be loaded. The entrypoint root must be computed each time a new file is:loaded.This PR also adds shelltests for the REPL commands.