Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Format returns 0 when file is not formatted #2181

Merged
merged 3 commits into from
Jun 7, 2023
Merged

Format returns 0 when file is not formatted #2181

merged 3 commits into from
Jun 7, 2023

Conversation

vrom911
Copy link
Contributor

@vrom911 vrom911 commented Jun 6, 2023 •
edited by jonaprieto
Loading

format command now returns code 0 most of the time.

It will return 1 when:

  • some error occur, so can not format
  • file is unformatted and --check option is used
  • One or more files are not formatted in a Juvix project.

@vrom911 vrom911 requested a review from paulcadman June 6, 2023 13:10
@vrom911 vrom911 self-assigned this Jun 6, 2023
paulcadman
paulcadman previously approved these changes Jun 6, 2023
View reviewed changes
Copy link
Collaborator

@paulcadman paulcadman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@jonaprieto jonaprieto force-pushed the vrom911/2171-format-1-code branch from 0e2bb1d to a54207b Compare June 7, 2023 10:43
@jonaprieto jonaprieto merged commit 8e59624 into main Jun 7, 2023
@jonaprieto jonaprieto deleted the vrom911/2171-format-1-code branch June 7, 2023 11:53
@jonaprieto jonaprieto added this to the 0.4 - Prague milestone Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulcadman paulcadman paulcadman approved these changes

Assignees

@vrom911 vrom911

Labels
juvix-formatter
Projects
None yet
Milestone
0.4 - Prague
Development

Successfully merging this pull request may close these issues.

Format command should not exit with 1 when needs formatting
3 participants
@vrom911 @paulcadman @jonaprieto