Add precondition to run tests #2887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janmasrovira
force-pushed
the
tests-precondition
branch
from
0ed1683 to
a445d2b
Compare
janmasrovira
force-pushed
the
tests-precondition
branch
from
a445d2b to
629926f
Compare
paulcadman
approved these changes
Jul 12, 2024
paulcadman
force-pushed
the
tests-precondition
branch
from
629926f to
3231452
Compare
|
This disables some tests even when they can be run with the internal interpreter (CASM tests) but the external VM is unavailable |
|
Ah, but perhaps that's OK if the whole subtree fails |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some tests require external dependencies, such as
rustc,wasmer,run_cairo_vm.sh, etc. If one does not have some of these available on their computer, then the test suite will have a lot of failed tests with the same fail messageX is not on $PATH. This can be a bit ditracting and it slows running the test suite.I've introduced some preconditions that are checked before the actual test suite so that if some of these commands are not on path then the tests that need them are not run. Instead, you get a single failed test (for each of the subtrees that failed the precondition).