Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support writing UTC adjusted time arrow array to parquet #6277

Closed
aykut-bozkurt opened this issue Aug 20, 2024 · 1 comment · Fixed by #6278
Closed

Support writing UTC adjusted time arrow array to parquet #6277

aykut-bozkurt opened this issue Aug 20, 2024 · 1 comment · Fixed by #6278
Labels
enhancement Any new improvement worthy of a entry in the changelog parquet Changes to the parquet crate

Comments

@aykut-bozkurt
Copy link
Contributor

aykut-bozkurt commented Aug 20, 2024

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
To support writing Time with timezone array to parquet in a similar way to how we write Timestamp with timezone. Currently, Time arrays are always converted to parquet with no timezone. (see fn arrow_to_parquet_type)

Describe the solution you'd like
We can check optional metadata key called adjusted_to_utc instead of always filling parquet's is_adjusted_to_utc false during the conversion. That would not cause any API change.

Describe alternatives you've considered
Add timezone string as second tuple field to arrow_schema::DataType::Time32 and arrow_schema::DataType::Time64. This is how it is done for Timestamp, which would cause an API change.

@aykut-bozkurt aykut-bozkurt added the enhancement Any new improvement worthy of a entry in the changelog label Aug 20, 2024
@aykut-bozkurt aykut-bozkurt changed the title Support writing UTC adjusted time with timezone arrow array to parquet Support writing UTC adjusted time with timezone arrow array to parquet Aug 20, 2024
@aykut-bozkurt aykut-bozkurt changed the title Support writing UTC adjusted time with timezone arrow array to parquet Support writing UTC adjusted time arrow array to parquet Aug 22, 2024
@alamb alamb added the parquet Changes to the parquet crate label Aug 31, 2024
@alamb
Copy link
Contributor

alamb commented Aug 31, 2024

label_issue.py automatically added labels {'parquet'} from #6278

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Any new improvement worthy of a entry in the changelog parquet Changes to the parquet crate
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants