Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Primitive binary/unary are not as fast as they could be #6364

Closed
AdamGS opened this issue Sep 6, 2024 · 2 comments
Closed

Primitive binary/unary are not as fast as they could be #6364

AdamGS opened this issue Sep 6, 2024 · 2 comments
Labels
arrow Changes to the arrow crate

Comments

@AdamGS
Copy link
Contributor

AdamGS commented Sep 6, 2024

While implementing on spiraldb/vortex#726 Implementing our own version of unary/binary, I realized that operating on fixed-sized slices yields much better performance (at least on my machine).
@AdamGS AdamGS mentioned this issue Sep 6, 2024
Closed
@AdamGS
Copy link
Contributor Author

AdamGS commented Sep 9, 2024

Code had a bug, tests passed because the case wasn't covered (arrays with more than 1024 elements)

@AdamGS AdamGS closed this as completed Sep 9, 2024
@alamb alamb added the arrow Changes to the arrow crate label Oct 2, 2024
@alamb
Copy link
Contributor

alamb commented Oct 2, 2024

label_issue.py automatically added labels {'arrow'} from #6365

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
arrow Changes to the arrow crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make unary and binary faster AdamGS/arrow-rs
2 participants
@alamb @AdamGS