Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release arrow-rs / parquet minor version 53.4.0 (Jan 2025) #6887

Closed
9 of 14 tasks
alamb opened this issue Dec 16, 2024 · 17 comments
Closed
9 of 14 tasks

Release arrow-rs / parquet minor version 53.4.0 (Jan 2025) #6887

alamb opened this issue Dec 16, 2024 · 17 comments
Assignees
Labels
arrow Changes to the arrow crate arrow-flight Changes to the arrow-flight crate development-process Related to development process of arrow-rs documentation Improvements or additions to documentation enhancement Any new improvement worthy of a entry in the changelog object-store Object Store Interface parquet Changes to the parquet crate

Comments

@alamb
Copy link
Contributor

alamb commented Dec 16, 2024

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

Our release schedule is here https://github.com/apache/arrow-rs?tab=readme-ov-file#release-versioning-and-schedule

However, upstream in DataFusion we are planning to release without picking up arrow 54 until after DataFusion 44

However, there are several fixes / features (related to Utf8View support for example) that we would like to make available downstream before we release DataFusion 45 and thus I would like to propose another release from the 44 branch

Describe the solution you'd like

Create a 53.4.0 release:

Describe alternatives you've considered

I think @andygrove would like to make

apache/datafusion#13334 (comment)

I am +1 for releasing DF 44 without the next major version of Arrow. However, there are some bug fixes and performance improvements in Arrow that I would like to use so would like to see a new minor release (and am happy to help with this if needed).

Process:

I will create the release from the https://github.com/apache/arrow-rs/tree/53.0.0_maintenance branch

To include patches in this release, please create PRs targeting the 53.0.0_maintenance branch. Once that branch has the desired content we can cut the release

Additional context

Planned content (please add more if necessary)

Possibly (if someone makes backport PRs):

here is the complete list of commits in 53.3.3 --> 54.0.0 for consideration:

@alamb alamb added the enhancement Any new improvement worthy of a entry in the changelog label Dec 16, 2024
@andygrove
Copy link
Member

@himadripal I added #6836 for consideration for this point release

@alamb
Copy link
Contributor Author

alamb commented Dec 20, 2024

Update:

Next steps are to start creating PRs (one or many) with the desired changes cherry-picked / backported targeting the 53.0.0_maintenance branch

@alamb
Copy link
Contributor Author

alamb commented Jan 6, 2025

Update here is we have begun making backports of select PRS to the 53.0.0_maintenance branch, for example:

I personally plan to create PRs for string view related functionality and what I view as important bugs (in the "planned content" heading above). If anyone else would like something else, please make a PR targeting the 53.0.0 branch

I plan to make a release candidate around Jan 15, 2025

@alamb
Copy link
Contributor Author

alamb commented Jan 10, 2025

I have completed backporting the PRs I have planned.

If anyone else would like to make a backport PR please do; I plan to cut a RC next week as planned

@emilk
Copy link
Contributor

emilk commented Jan 10, 2025

I would love to get this in if I can:

@alamb
Copy link
Contributor Author

alamb commented Jan 11, 2025

@alamb
Copy link
Contributor Author

alamb commented Jan 14, 2025

Also suggests:

I don't think I will be able to get this one in in time, so I will begin work on the RC now

@alamb
Copy link
Contributor Author

alamb commented Jan 14, 2025

Here is a PR to update version + changlog:

@alamb
Copy link
Contributor Author

alamb commented Jan 14, 2025

I made an RC but it currently fails like this:

failures:

---- bad_data::test_invalid_files stdout ----
thread 'bad_data::test_invalid_files' panicked at parquet/tests/arrow_reader/bad_data.rs:65:9:
Found new file in bad_data, please add test: ARROW-GH-45185.parquet
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace


failures:
    bad_data::test_invalid_files

test result: FAILED. 52 passed; 1 failed; 1 ignored; 0 measured; 0 filtered out; finished in 0.73s

error: test failed, to rerun pass `-p parquet --test arrow_reader`
+ cleanup
+ '[' no = yes ']'
+ echo 'Failed to verify release candidate. See /var/folders/1l/tg68jc6550gg8xqf1hr4mlwr0000gn/T/arrow-53.4.0.XXXXX.0Fd6xzcI2S for details.'
Failed to verify release candidate. See /var/folders/1l/tg68jc6550gg8xqf1hr4mlwr0000gn/T/arrow-53.4.0.XXXXX.0Fd6xzcI2S for details.

I need to update the test. I will do so tomorrow

@alamb
Copy link
Contributor Author

alamb commented Jan 15, 2025

@alamb
Copy link
Contributor Author

alamb commented Jan 15, 2025

We now have a vote thread outstanding:

@alamb
Copy link
Contributor Author

alamb commented Jan 18, 2025

The release was approved and published
https://lists.apache.org/thread/5nf1wnnxwsl85w1t9201fj6z8pk19043

@alamb alamb closed this as completed Jan 18, 2025
@alamb alamb added the arrow Changes to the arrow crate label Jan 27, 2025
@alamb
Copy link
Contributor Author

alamb commented Jan 27, 2025

label_issue.py automatically added labels {'arrow'} from #6956

@alamb alamb added the parquet Changes to the parquet crate label Jan 27, 2025
@alamb
Copy link
Contributor Author

alamb commented Jan 27, 2025

label_issue.py automatically added labels {'parquet'} from #6985

@alamb alamb added the documentation Improvements or additions to documentation label Jan 27, 2025
@alamb
Copy link
Contributor Author

alamb commented Jan 27, 2025

label_issue.py automatically added labels {'documentation'} from #6896

@alamb alamb added the arrow-flight Changes to the arrow-flight crate label Jan 27, 2025
@alamb
Copy link
Contributor Author

alamb commented Jan 27, 2025

label_issue.py automatically added labels {'arrow-flight'} from #6964

@alamb alamb added the object-store Object Store Interface label Jan 27, 2025
@alamb
Copy link
Contributor Author

alamb commented Jan 27, 2025

label_issue.py automatically added labels {'object-store'} from #6964

@alamb alamb added the development-process Related to development process of arrow-rs label Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate arrow-flight Changes to the arrow-flight crate development-process Related to development process of arrow-rs documentation Improvements or additions to documentation enhancement Any new improvement worthy of a entry in the changelog object-store Object Store Interface parquet Changes to the parquet crate
Projects
None yet
Development

No branches or pull requests

3 participants