Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor: Fix deprecated note to point to the correct const #7067

Closed
Omega359 opened this issue Feb 2, 2025 · 1 comment · Fixed by #7105
Closed

Minor: Fix deprecated note to point to the correct const #7067

Omega359 opened this issue Feb 2, 2025 · 1 comment · Fixed by #7105
Labels
arrow Changes to the arrow crate bug good first issue Good for newcomers

Comments

@Omega359
Copy link
Contributor

Omega359 commented Feb 2, 2025

Describe the bug

note = "Use MIN_DECIMAL_FOR_EACH_PRECISION (note indexes are different)"

#[deprecated(
    since = "54.1.0",
    note = "Use MIN_DECIMAL_FOR_EACH_PRECISION (note indexes are different)"
)]
pub const MIN_DECIMAL_FOR_EACH_PRECISION: [i128; 38] = [

That I believe should be

note = "Use MIN_DECIMAL128_FOR_EACH_PRECISION (note indexes are different)"

To Reproduce

Expected behavior

Additional context

@Omega359 Omega359 added the bug label Feb 2, 2025
@alamb alamb added the good first issue Good for newcomers label Feb 6, 2025
@alamb alamb added the arrow Changes to the arrow crate label Feb 10, 2025
@alamb
Copy link
Contributor

alamb commented Feb 10, 2025

label_issue.py automatically added labels {'arrow'} from #7105

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate bug good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants