From 088ad010a6ceaa6a2e810d418a2370e45acf3d54 Mon Sep 17 00:00:00 2001 From: junxiangMu <63799833+guojidan@users.noreply.github.com> Date: Thu, 30 May 2024 01:08:14 -0400 Subject: [PATCH] Chore: clean up udwf example && remove edundant import (#10718) Signed-off-by: guojidan <1948535941@qq.com> --- .../examples/simplify_udwf_expression.rs | 12 ------------ datafusion/proto-common/src/to_proto/mod.rs | 2 -- 2 files changed, 14 deletions(-) diff --git a/datafusion-examples/examples/simplify_udwf_expression.rs b/datafusion-examples/examples/simplify_udwf_expression.rs index 2824d03761ab..4e8d03c38e00 100644 --- a/datafusion-examples/examples/simplify_udwf_expression.rs +++ b/datafusion-examples/examples/simplify_udwf_expression.rs @@ -68,18 +68,6 @@ impl WindowUDFImpl for SimplifySmoothItUdf { /// this function will simplify `SimplifySmoothItUdf` to `SmoothItUdf`. fn simplify(&self) -> Option { - // Ok(ExprSimplifyResult::Simplified(Expr::WindowFunction( - // WindowFunction { - // fun: datafusion_expr::WindowFunctionDefinition::AggregateFunction( - // AggregateFunction::Avg, - // ), - // args, - // partition_by: partition_by.to_vec(), - // order_by: order_by.to_vec(), - // window_frame: window_frame.clone(), - // null_treatment: *null_treatment, - // }, - // ))) let simplify = |window_function: datafusion_expr::expr::WindowFunction, _: &dyn SimplifyInfo| { Ok(Expr::WindowFunction(WindowFunction { diff --git a/datafusion/proto-common/src/to_proto/mod.rs b/datafusion/proto-common/src/to_proto/mod.rs index e53604fc748c..f160bc40af39 100644 --- a/datafusion/proto-common/src/to_proto/mod.rs +++ b/datafusion/proto-common/src/to_proto/mod.rs @@ -289,8 +289,6 @@ impl TryFrom<&ScalarValue> for protobuf::ScalarValue { type Error = Error; fn try_from(val: &ScalarValue) -> Result { - use protobuf::scalar_value::Value; - let data_type = val.data_type(); match val { ScalarValue::Boolean(val) => {