-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overflow bug in POW scalar function (found by SQLancer) #11075
Comments
take |
this is the third, scalar function that panics instead of returning an error, maybe it's a good idea to open up a separate tracking issue to find all of these cases? |
I think it's a great idea. Those bugs are all very likely only related to function implementation body, and don't require modifying execution core code to fix, we can open a tracking issue for all function-local bugs(and also label "good first issue" if someone wants to help) Now only just a few types/functions has been fuzzed, I'm expecting more function-local bugs to appear. Also thank you so much for fixing them @LorrensP-2158466 👍🏼 |
That's right, fixing GCD & LCM was very local, only to the actual implementation of the algorithm, the API already allowed to return error's. I expect that will also be the case for the others.
I agree Thanks! You have made a very cool tool, because I would have never thought about this, and I think a lot of other neither. |
Describe the bug
The following statement should return an error instead of directly crash
Found by SQLancer #11030
To Reproduce
No response
Expected behavior
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: