-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Arrays for the Map scalar functions #11436
Comments
take |
MakeMap is possible to be removed after #11434, so you can find out array support for |
Apologies for the delay, prioritizing this issue. |
Sharing my observation from Observations
I am considering introducing a boolean flag to differentiate whether the function was invoked from a Map expression or a map function call. And handle the invocation accordingly |
In general, I think DataFuion strives not to invent / determine semantics, so in my opinion we should follow other implementations rather than having our own custom behavior whenever possible. I think by default we should follow the postgres model If postgres doesn't support maps / this syntax then I think we should follow the DuckDB model |
@dharanad I think |
I totally agree with you. |
Thanks for clarifying, i will have to say that i totally misunderstood the problem here. Should have checked what Postgres/DuckDB were doing & clarified the problem. |
Is your feature request related to a problem or challenge?
As @alamb mentioned in #11361 (comment), we should support not only scalar lists but also arrays for the
map
andmake_map
functions. However, I encountered some challenges, which I detailed in #11361 (comment). I left the disabled test cases indatafusion/datafusion/sqllogictest/test_files/map.slt
Lines 200 to 214 in 1dfac86
Describe the solution you'd like
No response
Describe alternatives you've considered
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: