-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce repetition in try_process_group_by_unnest
and try_process_unnest
#11498
Comments
try_process_group_by_unnest
and try_process_unnest
take |
After testing, it is found that the following logic is necessary even if the unnest has been processed by datafusion/datafusion/sql/src/select.rs Lines 311 to 344 in 2f5e73c
|
I wonder if there's a better way to handle this, such as planning unnest before aggregation, and then reusing the current group-by planning logic. This seems more intuitive to me. But I'm not sure about it.
Originally posted by @jonahgao in #11469 (comment)
The idea is to remove the repetition, and possibly also this comment as well: https://github.com/apache/datafusion/pull/11469/files#r1678995060
The text was updated successfully, but these errors were encountered: