-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Supporting casts to timestamptz: Eq Utf8 of binary physical should be same" #5164
Comments
@alamb I'll take it if noone else will. Need to finish this off |
@alamb @waitingkuo likely we have some design issues on TimestampTz please consider such simple case
Ive put ???????? as its not really clear what has to be there, |
In terms of cc @tustvold in case he has additional thoughts |
I agree, we should adjust the timestamp from the timezone in the string, if any, to time since UTC epoch, and store this in the value. The timezone of the output can then be the DataFusion default, unless otherwise specified, regardless this doesn't impact the encoded value which is always time since UTC epoch |
Waiting arrow 34.0.0 |
That finally works after Arrow 36.0.0, I'll create a PR with tests |
Describe the bug
After #5140 and #5117 we can cast strings to Timestamp without a timezone. However, casting with timezone is not working yet, as noticed by @waitingkuo
To Reproduce
In
datafusion-cli
:Expected behavior
I expect all three queries to run and return
true
Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered: