only consider main part of the url when deciding is_collection in listing table #10419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
approved these changes
May 8, 2024
There was a problem hiding this comment.
Thank you for this contribution @y-f-u and @phillipleblanc
I have kicked off the CI and assuming it passes I think this PR will be good to merge
|
I took the liberty of running |
|
Thanks again @y-f-u and @phillipleblanc |
findepi
pushed a commit
to findepi/datafusion
that referenced
this pull request
Jul 16, 2024
…ting table (apache#10419) * only consider main part of the url when deciding is_collection in listing table * use url path * run `cargo fmt` --------- Co-authored-by: Andrew Lamb <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Query string and fragment should not be considered when deciding if the path is a collection
Will open one if needed, but the PR itself is descriptive enough.
Rationale for this change
See tests in the PR. It can be common if a remote object store takes query string or fragment for other perspective, e.g. tracking.
Are these changes tested?
Yes
Are there any user-facing changes?
No