Simplify making information_schame tables #10420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Weijun-H
reviewed
May 8, 2024
Weijun-H
approved these changes
May 8, 2024
comphead
reviewed
May 8, 2024
comphead
reviewed
May 8, 2024
| INFORMATION_SCHEMA_TABLES | ||
| .iter() | ||
| .map(|t| t.to_string()) | ||
| .collect() | ||
| } | ||
|
|
||
| async fn table( | ||
| &self, | ||
| name: &str, | ||
| ) -> Result<Option<Arc<dyn TableProvider>>, DataFusionError> { |
There was a problem hiding this comment.
Not related to this PR but do we need Result in return 🤔
There was a problem hiding this comment.
I think it is related to the fact this is in the implementation of the SchemaProvider trait
|
I am surprised that this pr passed the tests, how about adding some tests for it? |
I added a test in slt. |
alamb
approved these changes
May 8, 2024
| INFORMATION_SCHEMA_TABLES | ||
| .iter() | ||
| .map(|t| t.to_string()) | ||
| .collect() | ||
| } | ||
|
|
||
| async fn table( | ||
| &self, | ||
| name: &str, | ||
| ) -> Result<Option<Arc<dyn TableProvider>>, DataFusionError> { |
There was a problem hiding this comment.
I think it is related to the fact this is in the implementation of the SchemaProvider trait
findepi
pushed a commit
to findepi/datafusion
that referenced
this pull request
Jul 16, 2024
* Simplify making information_schame tables * Simplify InformationSchemaProvider * Remove lifetime annotation * Replace if with match * case insensitive * Add test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Simplify making information_schame tables and avoid potential bug that someone forgets adding logic for new table here.
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?