Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor: Improved document string for LogicalPlanBuilder #10496

Merged
merged 1 commit into from
May 14, 2024

Conversation

AbrarNitk
Copy link
Contributor

@AbrarNitk AbrarNitk commented May 14, 2024

Which issue does this PR close?

This pull request contains missing document for PR #10466
Closes: #10465.

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added the logical-expr Logical plan and expressions label May 14, 2024
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @AbrarNitk -- very nice improvement. Thanks for the follow up

@alamb alamb changed the title Improved document string for plan builder Minor: Improved document string for plan builder May 14, 2024
@alamb alamb changed the title Minor: Improved document string for plan builder Minor: Improved document string for LogicalPlanBuilder May 14, 2024
@alamb alamb added the documentation Improvements or additions to documentation label May 14, 2024
@alamb alamb merged commit 424757f into apache:main May 14, 2024
24 of 25 checks passed
@AbrarNitk AbrarNitk deleted the improved-doc/plan-builder branch May 15, 2024 05:53
findepi pushed a commit to findepi/datafusion that referenced this pull request Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation logical-expr Logical plan and expressions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement LogicalPlanBuilder::from for Arc<LogicalPlan>
2 participants