-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor: remove unused source file udf.rs
#10497
Conversation
udf.rs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @jonahgao -- this is a great find!
I also double checked a few of these UDFs and found their second copy
🧹
} | ||
} | ||
|
||
make_udf_function!( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is the current copy of the code
datafusion/datafusion/functions-array/src/dimension.rs
Lines 45 to 50 in cd36ee3
pub(super) struct ArrayDims { | |
signature: Signature, | |
aliases: Vec<String>, | |
} | |
impl ArrayDims { |
use std::sync::Arc; | ||
|
||
// Create static instances of ScalarUDFs for each function | ||
make_udf_function!(ArrayToString, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is the other copy:
datafusion/datafusion/functions-array/src/string.rs
Lines 113 to 132 in cd36ee3
pub(super) struct ArrayToString { | |
signature: Signature, | |
aliases: Vec<String>, | |
} | |
impl ArrayToString { | |
pub fn new() -> Self { | |
Self { | |
signature: Signature::variadic_any(Volatility::Immutable), | |
aliases: vec![ | |
String::from("array_to_string"), | |
String::from("list_to_string"), | |
String::from("array_join"), | |
String::from("list_join"), | |
], | |
} | |
} | |
} | |
impl ScalarUDFImpl for ArrayToString { |
Thank you for double-checking @alamb . |
Which issue does this PR close?
N/A
Rationale for this change
I have checked that all the UDFs in the file have already been implemented in other modules.
Moreover, udf.rs is not appearing in lib.rs.
What changes are included in this PR?
Are these changes tested?
Yes. By existing tests.
Are there any user-facing changes?
No