chore: use fullpath in macro to avoid declaring in other module #10503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jayzhan211 <[email protected]>
jayzhan211
changed the title
jayzhan211
changed the title
alamb
approved these changes
May 14, 2024
There was a problem hiding this comment.
Looks like a very nice PR to me -- thank you @jayzhan211
(I think @crepererum calls this "macro hygene" 👍 )
findepi
pushed a commit
to findepi/datafusion
that referenced
this pull request
Jul 16, 2024
Signed-off-by: jayzhan211 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
cleanup code. The benefit is that we don't need to import for macro.
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?