Minor: Move proxy to datafusion common #10561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jayzhan211 <[email protected]>
jayzhan211
changed the title
github-actions
bot
added
physical-expr
Signed-off-by: jayzhan211 <[email protected]>
alamb
reviewed
May 17, 2024
There was a problem hiding this comment.
Looks good to me @jayzhan211 other than the name of the new memory_pool module -- maybe we can just put it in utils instead
| // specific language governing permissions and limitations | ||
| // under the License. | ||
|
|
||
| pub mod proxy; |
There was a problem hiding this comment.
I think moving the proxy code (that helps track allocations) makes sense to me
What do you think about putting it somewhere other than a directory called "memory_pool"
Perhaps datafusion/common/src/utils/proxy.rs 🤔
Signed-off-by: jayzhan211 <[email protected]>
Signed-off-by: jayzhan211 <[email protected]>
comphead
reviewed
May 18, 2024
| @@ -74,7 +74,7 @@ datafusion-common = { workspace = true } | |||
| datafusion-execution = { workspace = true } | |||
| datafusion-expr = { workspace = true } | |||
| datafusion-physical-expr = { workspace = true, default-features = true } | |||
| hashbrown = { version = "0.14", features = ["raw"], optional = true } | |||
| hashbrown = { workspace = true, optional = true } | |||
findepi
pushed a commit
to findepi/datafusion
that referenced
this pull request
Jul 16, 2024
* move proxy to common Signed-off-by: jayzhan211 <[email protected]> * fix doc Signed-off-by: jayzhan211 <[email protected]> * move to utils Signed-off-by: jayzhan211 <[email protected]> * fix doc Signed-off-by: jayzhan211 <[email protected]> --------- Signed-off-by: jayzhan211 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Part of #10484
Rationale for this change
These two allocExtension is used in binary map (datafusion/physical-expr/src/binary_map.rs), which is planned to move to
functions-aggregate, so I move it to common to avoid importing execution crate.What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?