Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve ContextProvider #10577

Merged
merged 1 commit into from
May 21, 2024
Merged

Conversation

lewiszlw
Copy link
Member

Which issue does this PR close?

Renaming like SchemaProvider::table_names, add docs and remove deprecated code.

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added sql SQL Planner optimizer Optimizer rules core Core DataFusion crate labels May 20, 2024
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lewiszlw -- I think this is a nice change, even if it is a breaking API change I think the new names are much better and the change required is mechanical

@alamb alamb added the api change Changes the API exposed to users of the crate label May 20, 2024
@alamb
Copy link
Contributor

alamb commented May 20, 2024

I'll leave this open for a day as it is an API change, in case anyone else wants a chance to review

@comphead comphead merged commit aab40e1 into apache:main May 21, 2024
23 checks passed
findepi pushed a commit to findepi/datafusion that referenced this pull request Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api change Changes the API exposed to users of the crate core Core DataFusion crate optimizer Optimizer rules sql SQL Planner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants