Speed up arrow_statistics test #10735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
commented
May 31, 2024
| /// The parquet file reader | ||
| reader: ParquetRecordBatchReaderBuilder<File>, | ||
| reader: &'a ParquetRecordBatchReaderBuilder<File>, |
There was a problem hiding this comment.
the change is to reuse the reader rather than recreating it each time
jonahgao
approved these changes
Jun 3, 2024
|
We got lots of statistics PRs so conflicts are unavoidable |
Thanks for the heads up @comphead -- I plan to get the other statistics tests in first and then I will merge / fixup this one |
|
THe other statistics PRs have been merged and I resolved conflicts in this branch. |
comphead
approved these changes
Jun 4, 2024
findepi
pushed a commit
to findepi/datafusion
that referenced
this pull request
Jul 16, 2024
* Speed up arrow_statistics test * resolve logical conflicts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #10453
Rationale for this change
Currently arrow_statistics take multiple seconds on my local machine (see screenshot)
This is because they make the same parquet file over and over again.
What changes are included in this PR?
Update the test to reuse the created parquet files
Are these changes tested?
They are all tests. Now they go 2x faster on my local machine:
Are there any user-facing changes?
No this is all tests