Handle empty rows for array_sort
#10786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jayzhan211 <[email protected]>
jayzhan211
force-pushed
the
array-sort-empty
branch
from
05c5766 to
9b1e7a0
Compare
Dandandan
approved these changes
Jun 4, 2024
|
Thanks @Dandandan ! |
findepi
pushed a commit
to findepi/datafusion
that referenced
this pull request
Jul 16, 2024
Signed-off-by: jayzhan211 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #10772.
Rationale for this change
If the row fail to match the filter condition, it has empty rows (row count is 0), so we should handle this edge case
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?