Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement TPCH substrait integration test, support tpch_13, tpch_14,16 #11405

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

Lordworms
Copy link
Contributor

part of #10710

Which issue does this PR close?

Closes #.

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@Lordworms
Copy link
Contributor Author

query 15 is missing. I'll add the missing queries once I have done the existing ones.

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Lordworms 🙏

I think @Blizzara added a clearner way to setup the contexts in #11396

Would it be possible to use that new pattern in this PR too?

@Lordworms
Copy link
Contributor Author

Thanks @Lordworms 🙏

I think @Blizzara added a clearner way to setup the contexts in #11396

Would it be possible to use that new pattern in this PR too?

Sure

@github-actions github-actions bot added sql SQL Planner logical-expr Logical plan and expressions physical-expr Physical Expressions optimizer Optimizer rules core Core DataFusion crate sqllogictest SQL Logic Tests (.slt) labels Jul 12, 2024
@github-actions github-actions bot removed sql SQL Planner logical-expr Logical plan and expressions physical-expr Physical Expressions optimizer Optimizer rules core Core DataFusion crate sqllogictest SQL Logic Tests (.slt) labels Jul 12, 2024
Copy link
Contributor

@Blizzara Blizzara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@alamb
Copy link
Contributor

alamb commented Jul 12, 2024

Thanks again @Blizzara and @Lordworms 🚀

@alamb alamb merged commit bd25e26 into apache:main Jul 12, 2024
23 checks passed
findepi pushed a commit to findepi/datafusion that referenced this pull request Jul 16, 2024
xinlifoobar pushed a commit to xinlifoobar/datafusion that referenced this pull request Jul 17, 2024
xinlifoobar pushed a commit to xinlifoobar/datafusion that referenced this pull request Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants