Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve update error #7777

Merged
merged 4 commits into from
Oct 13, 2023
Merged

Improve update error #7777

merged 4 commits into from
Oct 13, 2023

Conversation

lewiszlw
Copy link
Member

@lewiszlw lewiszlw commented Oct 9, 2023

Which issue does this PR close?

improve update error.

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added logical-expr Logical plan and expressions core Core DataFusion crate labels Oct 9, 2023
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much @lewiszlw 🙏

Copy link
Member

@Weijun-H Weijun-H left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we use dml.op instead of deriving Copy?

@alamb
Copy link
Contributor

alamb commented Oct 13, 2023

Thanks again @lewiszlw

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core DataFusion crate logical-expr Logical plan and expressions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants