Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor: Update datafusion-cli README to explain why it is not in the w… #8938

Merged
merged 2 commits into from
Jan 22, 2024

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Jan 21, 2024

…orkspace

Which issue does this PR close?

N/A

Rationale for this change

As part of #8918 @trungda noted it was not clear why datafusion-cli was not part of the main workspace #8918 (comment)

There is a reason but it is not obvious, so let's document that

What changes are included in this PR?

  1. Update datafusion-cli README

Are these changes tested?

existing CI

Are there any user-facing changes?

@alamb alamb marked this pull request as ready for review January 21, 2024 16:25
Copy link
Contributor

@comphead comphead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks @alamb

@alamb alamb merged commit 180cbfb into apache:main Jan 22, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants