Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor: Add comments to MSRV CI check to help if it fails #8995

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Jan 25, 2024

Which issue does this PR close?

N/A

Rationale for this change

Not everyone may be familiar with what MSRV means and what to do to fix this CI check (e.g. #8961) so it would be good to document it for anyone else that hits it

What changes are included in this PR?

  1. Add comments / documentation to the MSRV CI check explaining what it is and how to fix it

Are these changes tested?

By CI

Are there any user-facing changes?

@alamb alamb added the development-process Related to development process of DataFusion label Jan 25, 2024
@github-actions github-actions bot removed the development-process Related to development process of DataFusion label Jan 25, 2024
@alamb alamb mentioned this pull request Jan 25, 2024
Copy link
Contributor

@mustafasrepo mustafasrepo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @alamb for this update.

@alamb alamb merged commit 80a42bf into apache:main Jan 25, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants