Minor: reduce unwraps in datetime_expressions.rs #9072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trungda
approved these changes
Jan 30, 2024
comphead
reviewed
Jan 30, 2024
| @@ -556,30 +556,25 @@ pub fn make_date(args: &[ColumnarValue]) -> Result<ColumnarValue> { | |||
| let m = u32::try_from(value_fn(&months, i)?); | |||
| let d = u32::try_from(value_fn(&days, i)?); | |||
|
|
|||
| if m.is_err() { | |||
| let Ok(m) = m else { | |||
comphead
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Follow on to #9040
Rationale for this change
Implement code suggestion I had while reviewing: #9040 (comment)
There are several other uses of
unwrapin datetime_expressions.rs that can probably be removed for cleaner code, but I don't think it is critical.What changes are included in this PR?
Minor refactor to remove some
unwrapAre these changes tested?
Covered by existing tests
Are there any user-facing changes?
No